Optimize BandCenter and IntersticeDistribution featurizers
#897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/optimizations
branch
from
74c1ef2 to
5324ea6
Compare
|
Only tests are failing as I don't have access to the MP API key from my fork, will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply initialises various data sources at the class or instance level, rather than in the featurizer loop, which was causing the data sources to be loaded from disk for every featurization leading to serious performance issues (as one might expect).
BandCenter, for example, is now 5 orders of magnitude faster on my machine.I couldn't spot any other featurizers that have this issue though my search wasn't exhaustive.